Draft: subclass: Add missing BuildableImpl vfuncs #900
Conversation
|
I haven't got the time to clean things up, will get back to it pretty soon i hope |
| ); | ||
| fn custom_tag_end( | ||
| tag_name: &str, | ||
| parser_data: *mut *mut libc::c_void, |
There was a problem hiding this comment.
How is this pointer used exactly?
There was a problem hiding this comment.
It is used to pass the state to the BuildableParser, my idea was to create a struct that implements a certain trait and move the struct around instead of passing a random ptr around
There was a problem hiding this comment.
Sounds like a good plan :) Where would the struct be freed, is the finish() function guaranteed to be called exactly once with the same parser data, for example?
| } | ||
| } | ||
|
|
||
| pub unsafe trait BuildableParserImpl: Sized { |
There was a problem hiding this comment.
It shouldn't, I made it unsafe at first before figuring out what the user_data pointers are used for. Ideally once this PR is ready, we shouldn't need that
No description provided.